Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1027633003: [Effen] Add AnimatedComponent base class (Closed)

Created:
5 years, 9 months ago by rafaelw
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Add AnimatedComponent base class This patch adds a base AnimatedComponent from which most components that animated should derive. It takes care of listening & unlistening from the animations during did(Un)mount as well as binding the animated value to a private field and scheduling the component for build. Note that this patch removes the did(Un)mount overridable methods from Component and replaces them with a callback mechanism which is less brittle. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/465402ea49933d769293b3f657d90219d1ef3c24

Patch Set 1 #

Patch Set 2 : moar #

Total comments: 4

Patch Set 3 : cr changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -90 lines) Patch
M sky/framework/animation/animated_value.dart View 1 2 2 chunks +4 lines, -26 lines 0 comments Download
A sky/framework/components/animated_component.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M sky/framework/components/drawer.dart View 4 chunks +7 lines, -12 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M sky/framework/components/ink_well.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sky/framework/components/input.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/framework/components/popup_menu.dart View 5 chunks +11 lines, -14 lines 0 comments Download
M sky/framework/components/popup_menu_item.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M sky/framework/components/scrollable.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M sky/framework/editing/editable_text.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M sky/framework/fn.dart View 3 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rafaelw
https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation/animated_value.dart File sky/framework/animation/animated_value.dart (right): https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation/animated_value.dart#newcode16 sky/framework/animation/animated_value.dart:16: _value = initial; Note: this prevents the initial value ...
5 years, 9 months ago (2015-03-20 05:36:00 UTC) #2
abarth-chromium
LGTM That's really slick. https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation/animated_value.dart File sky/framework/animation/animated_value.dart (right): https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation/animated_value.dart#newcode16 sky/framework/animation/animated_value.dart:16: _value = initial; On 2015/03/20 ...
5 years, 9 months ago (2015-03-20 05:41:49 UTC) #3
rafaelw
Committed patchset #3 (id:40001) manually as 465402ea49933d769293b3f657d90219d1ef3c24 (presubmit successful).
5 years, 9 months ago (2015-03-20 05:49:45 UTC) #4
rafaelw
5 years, 9 months ago (2015-03-20 05:52:31 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation...
File sky/framework/animation/animated_value.dart (right):

https://codereview.chromium.org/1027633003/diff/20001/sky/framework/animation...
sky/framework/animation/animated_value.dart:16: _value = initial;
On 2015/03/20 05:41:49, abarth wrote:
> On 2015/03/20 at 05:36:00, rafaelw wrote:
> > Note: this prevents the initial value from being broadcast in the stream.
> Consumers are expected to retrieve the initial value via the accessor.
> 
> Maybe add a comment explaining this subtle point?

Done.

Powered by Google App Engine
This is Rietveld 408576698