Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: sky/framework/components/ink_well.dart

Issue 1027633003: [Effen] Add AnimatedComponent base class (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/components/fixed_height_scrollable.dart ('k') | sky/framework/components/input.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/ink_well.dart
diff --git a/sky/framework/components/ink_well.dart b/sky/framework/components/ink_well.dart
index 601e3c75102a31e812146ae690548a3d9a8ac5c2..6f452694f7b34e7bd6cfdf4f9637a0d2e43b3cd1 100644
--- a/sky/framework/components/ink_well.dart
+++ b/sky/framework/components/ink_well.dart
@@ -15,7 +15,11 @@ class InkWell extends Component {
List<Node> children;
InkWell({ Object key, this.style, this.inlineStyle, this.children })
- : super(key: key);
+ : super(key: key) {
+ onDidUnmount(() {
+ _cancelSplashes(null);
+ });
+ }
Node build() {
List<Node> childrenIncludingSplashes = [];
@@ -69,10 +73,6 @@ class InkWell extends Component {
});
}
- void didUnmount() {
- _cancelSplashes(null);
- }
-
void _splashDone(SplashController splash) {
if (_splashes == null)
return;
« no previous file with comments | « sky/framework/components/fixed_height_scrollable.dart ('k') | sky/framework/components/input.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698