Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: sky/framework/components/popup_menu_item.dart

Issue 1027633003: [Effen] Add AnimatedComponent base class (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: cr changes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/framework/components/popup_menu.dart ('k') | sky/framework/components/scrollable.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/popup_menu_item.dart
diff --git a/sky/framework/components/popup_menu_item.dart b/sky/framework/components/popup_menu_item.dart
index 7468ba0650ca190fef9182b5494475db538bf74d..707d5ad172ddab9d5fbbcaa6bee55bd3fe1c8e3e 100644
--- a/sky/framework/components/popup_menu_item.dart
+++ b/sky/framework/components/popup_menu_item.dart
@@ -2,32 +2,27 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+import 'animated_component.dart';
import '../animation/animated_value.dart';
import '../fn.dart';
import 'ink_well.dart';
-class PopupMenuItem extends Component {
+class PopupMenuItem extends AnimatedComponent {
static final Style _style = new Style('''
min-width: 112px;
padding: 16px;''');
List<Node> children;
- AnimatedValueListener _opacity;
+ double _opacity;
PopupMenuItem({ Object key, this.children, AnimatedValue opacity}) : super(key: key) {
- _opacity = new AnimatedValueListener(this, opacity);
- }
-
- void didUnmount() {
- _opacity.stopListening();
+ animateField(opacity, #_opacity);
}
Node build() {
- _opacity.ensureListening();
-
return new InkWell(
style: _style,
- inlineStyle: _opacity.value == null ? null : 'opacity: ${_opacity.value}',
+ inlineStyle: _opacity == null ? null : 'opacity: ${_opacity}',
children: children
);
}
« no previous file with comments | « sky/framework/components/popup_menu.dart ('k') | sky/framework/components/scrollable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698