Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter. (Closed)

Created:
5 years, 9 months ago by vivekg_samsung
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, bashi
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter. R=haraken@chromium.org BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/NativeValueTraits.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 11 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/V8BindingForModules.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/union.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.h View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestPermissiveDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/UnionTypesModules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/UnionTypesModules.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vivekg
PTAL.
5 years, 9 months ago (2015-03-20 04:28:38 UTC) #2
bashi
LGTM
5 years, 9 months ago (2015-03-20 04:39:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027613002/1
5 years, 9 months ago (2015-03-20 04:50:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192227
5 years, 9 months ago (2015-03-20 05:39:37 UTC) #7
haraken
5 years, 9 months ago (2015-03-20 06:06:59 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698