Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/bindings/tests/results/core/UnionTypesCore.h

Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/union.cpp ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/UnionTypesCore.h
diff --git a/Source/bindings/tests/results/core/UnionTypesCore.h b/Source/bindings/tests/results/core/UnionTypesCore.h
index c6c21d85eefce5afac5fc3d659a57663d0a5fa20..2fa6887d8b6da63114487b65c3b1537ba509fc34 100644
--- a/Source/bindings/tests/results/core/UnionTypesCore.h
+++ b/Source/bindings/tests/results/core/UnionTypesCore.h
@@ -78,7 +78,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, ArrayBufferOrArra
template <>
struct NativeValueTraits<ArrayBufferOrArrayBufferViewOrDictionary> {
- static ArrayBufferOrArrayBufferViewOrDictionary nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static ArrayBufferOrArrayBufferViewOrDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class BooleanOrStringOrUnrestrictedDouble final {
@@ -133,7 +133,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, BooleanOrStringOr
template <>
struct NativeValueTraits<BooleanOrStringOrUnrestrictedDouble> {
- static BooleanOrStringOrUnrestrictedDouble nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static BooleanOrStringOrUnrestrictedDouble nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class DoubleOrString final {
@@ -181,7 +181,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, DoubleOrString& i
template <>
struct NativeValueTraits<DoubleOrString> {
- static DoubleOrString nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static DoubleOrString nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class NodeOrNodeList final {
@@ -231,7 +231,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, NodeOrNodeList& i
template <>
struct NativeValueTraits<NodeOrNodeList> {
- static NodeOrNodeList nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static NodeOrNodeList nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class StringOrArrayBufferOrArrayBufferView final {
@@ -286,7 +286,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, StringOrArrayBuff
template <>
struct NativeValueTraits<StringOrArrayBufferOrArrayBufferView> {
- static StringOrArrayBufferOrArrayBufferView nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static StringOrArrayBufferOrArrayBufferView nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class StringOrDouble final {
@@ -334,7 +334,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, StringOrDouble& i
template <>
struct NativeValueTraits<StringOrDouble> {
- static StringOrDouble nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static StringOrDouble nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class StringOrStringSequence final {
@@ -382,7 +382,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, StringOrStringSeq
template <>
struct NativeValueTraits<StringOrStringSequence> {
- static StringOrStringSequence nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static StringOrStringSequence nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestEnumOrDouble final {
@@ -430,7 +430,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestEnumOrDouble&
template <>
struct NativeValueTraits<TestEnumOrDouble> {
- static TestEnumOrDouble nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestEnumOrDouble nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestInterface2OrUint8Array final {
@@ -478,7 +478,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterface2OrU
template <>
struct NativeValueTraits<TestInterface2OrUint8Array> {
- static TestInterface2OrUint8Array nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestInterface2OrUint8Array nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestInterfaceGarbageCollectedOrString final {
@@ -528,7 +528,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterfaceGarb
template <>
struct NativeValueTraits<TestInterfaceGarbageCollectedOrString> {
- static TestInterfaceGarbageCollectedOrString nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestInterfaceGarbageCollectedOrString nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestInterfaceOrLong final {
@@ -576,7 +576,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterfaceOrLo
template <>
struct NativeValueTraits<TestInterfaceOrLong> {
- static TestInterfaceOrLong nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestInterfaceOrLong nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestInterfaceOrTestInterfaceEmpty final {
@@ -624,7 +624,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterfaceOrTe
template <>
struct NativeValueTraits<TestInterfaceOrTestInterfaceEmpty> {
- static TestInterfaceOrTestInterfaceEmpty nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestInterfaceOrTestInterfaceEmpty nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class TestInterfaceWillBeGarbageCollectedOrTestDictionary final {
@@ -674,7 +674,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestInterfaceWill
template <>
struct NativeValueTraits<TestInterfaceWillBeGarbageCollectedOrTestDictionary> {
- static TestInterfaceWillBeGarbageCollectedOrTestDictionary nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static TestInterfaceWillBeGarbageCollectedOrTestDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class UnrestrictedDoubleOrString final {
@@ -722,7 +722,7 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, UnrestrictedDoubl
template <>
struct NativeValueTraits<UnrestrictedDoubleOrString> {
- static UnrestrictedDoubleOrString nativeValue(v8::Local<v8::Value>, v8::Isolate*, ExceptionState&);
+ static UnrestrictedDoubleOrString nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
class V8DoubleOrStringOrNull final {
« no previous file with comments | « Source/bindings/templates/union.cpp ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698