Source/bindings/core/v8/ScriptValue.h - Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptValue.h

Issue 1027613002: [bindings] Refactor NativeValueTraits<T>::nativeValue to accept isolate as first parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptValue.h

diff --git a/Source/bindings/core/v8/ScriptValue.h b/Source/bindings/core/v8/ScriptValue.h

index 4a727dd732a30cdab4624dc4af2e5e6e06244db8..f6255e8f27ba77baeb601b49efd8c935c32ba432 100644

--- a/Source/bindings/core/v8/ScriptValue.h

+++ b/Source/bindings/core/v8/ScriptValue.h

@@ -55,7 +55,7 @@ public:

template<typename T>

inline T to(ExceptionState& exceptionState) const

{

- return NativeValueTraits<T>::nativeValue(v8Value(), isolate(), exceptionState);

+ return NativeValueTraits<T>::nativeValue(isolate(), v8Value(), exceptionState);

}

ScriptValue() { }

« no previous file with comments | « Source/bindings/core/v8/NativeValueTraits.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »