Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: extensions/renderer/resources/guest_view/extension_view/extension_view.js

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/extension_view/extension_view.js
diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view.js b/extensions/renderer/resources/guest_view/extension_view/extension_view.js
index 9a132548a32d7ab55104f9e5448d6d3197027cc7..331f508748fc14d42cdfd59dd6863ee501b62871 100644
--- a/extensions/renderer/resources/guest_view/extension_view/extension_view.js
+++ b/extensions/renderer/resources/guest_view/extension_view/extension_view.js
@@ -13,7 +13,6 @@ var ExtensionViewInternal =
function ExtensionViewImpl(extensionviewElement) {
GuestViewContainer.call(this, extensionviewElement, 'extensionview');
- this.setupExtensionViewAttributes();
new ExtensionViewEvents(this, this.viewInstanceId);
}
@@ -42,16 +41,6 @@ ExtensionViewImpl.prototype.buildContainerParams = function() {
return params;
};
-// This observer monitors mutations to attributes of the <extensionview>.
-ExtensionViewImpl.prototype.handleAttributeMutation = function(
- attributeName, oldValue, newValue) {
- if (!this.attributes[attributeName])
- return;
-
- // Let the changed attribute handle its own mutation.
- this.attributes[attributeName].maybeHandleMutation(oldValue, newValue);
-};
-
ExtensionViewImpl.prototype.onElementDetached = function() {
this.guest.destroy();

Powered by Google App Engine
This is Rietveld 408576698