extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js - Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/extension_view/extension_view.js ('k') | extensions/renderer/resources/guest_view/guest_view_container.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js

diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js b/extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js

index d0786ed7962ac37b7869dc65152c87042e7dd9bb..59792b813e3bab3cf7e69db1aa80606e5447a81c 100644

--- a/extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js

+++ b/extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js

@@ -5,9 +5,9 @@

// This module implements the attributes of the <extensionview> tag.

var GuestViewAttributes = require('guestViewAttributes').GuestViewAttributes;

-var ExtensionViewImpl = require('extensionView').ExtensionViewImpl;

var ExtensionViewConstants =

require('extensionViewConstants').ExtensionViewConstants;

+var ExtensionViewImpl = require('extensionView').ExtensionViewImpl;

var ExtensionViewInternal =

require('extensionViewInternal').ExtensionViewInternal;

@@ -54,8 +54,7 @@ SrcAttribute.prototype.parse = function() {

// -----------------------------------------------------------------------------

// Sets up all of the extensionview attributes.

-ExtensionViewImpl.prototype.setupExtensionViewAttributes = function() {

- this.attributes = {};

+ExtensionViewImpl.prototype.setupAttributes = function() {

this.attributes[ExtensionViewConstants.ATTRIBUTE_EXTENSION] =

new ExtensionAttribute(this);

this.attributes[ExtensionViewConstants.ATTRIBUTE_SRC] =