extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js - Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js

Issue 1026703004: Refactored extensionOptions to use the new guestViewAttributes module. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/guest_view/extension_options/extension_options_attributes.js ('k') | extensions/renderer/resources/guest_view/extension_view/extension_view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js

diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js b/extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js

similarity index 51%

copy from extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js

copy to extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js

index b8f09699f4df66ccd179b586a60e8bc56f1fe38a..f9b29aeccd7cab99547b5b5eba10d7c034dfdf9c 100644

--- a/extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js

+++ b/extensions/renderer/resources/guest_view/extension_options/extension_options_constants.js

@@ -2,13 +2,12 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// This module contains constants used in extensionview.

+// This module contains constants used in extensionoptions.

// Container for the extensionview constants.

-var ExtensionViewConstants = {

+var ExtensionOptionsConstants = {

// Attributes.

- ATTRIBUTE_EXTENSION: 'extension',

- ATTRIBUTE_SRC: 'src',

+ ATTRIBUTE_EXTENSION: 'extension'

};

-exports.ExtensionViewConstants = $Object.freeze(ExtensionViewConstants);

+exports.ExtensionOptionsConstants = $Object.freeze(ExtensionOptionsConstants);