Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1026403002: Go back to storeAligned / LoadAligned for SkPMFloat <->Sk4f. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Go back to storeAligned / LoadAligned for SkPMFloat <->Sk4f. This seems to fix the miscompilation bug on ARM64 / Release / GCC 4.9. We switched this over originally for perf issues with NEON, but I can't see any now. Will keep an eye out. BUG=skia:3570 Committed: https://skia.googlesource.com/skia/+/4b65059e6eea7d90ff3547e4656f7659d3815dc4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/core/SkPMFloat.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PMFloatTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mtklein
lgtm
5 years, 9 months ago (2015-03-24 15:53:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026403002/1
5 years, 9 months ago (2015-03-24 15:53:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1026403002/1
5 years, 9 months ago (2015-03-24 16:47:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 16:47:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b65059e6eea7d90ff3547e4656f7659d3815dc4

Powered by Google App Engine
This is Rietveld 408576698