Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1025203002: Have postMessage()s throw TypeError on failed arity checks. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
haraken, Mike West, jsbell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tidy up incorrect postMessage() usage #

Messages

Total messages: 14 (3 generated)
sof
please take a look. It might be worth auditing other custom methods for same?
5 years, 9 months ago (2015-03-23 06:33:16 UTC) #2
Mike West
LGTM. Thanks for cleaning this up!
5 years, 9 months ago (2015-03-23 06:40:52 UTC) #3
haraken
LGTM
5 years, 9 months ago (2015-03-23 07:28:20 UTC) #4
sof
thanks; should there be tests (or content) that rely on worker.postMessage() posting 'undefined', we'll just ...
5 years, 9 months ago (2015-03-23 08:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025203002/20001
5 years, 9 months ago (2015-03-23 08:19:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192337
5 years, 9 months ago (2015-03-23 08:24:45 UTC) #8
dglazkov
On 2015/03/23 at 08:24:45, commit-bot wrote: > Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192337 Is this ...
5 years, 9 months ago (2015-03-23 14:59:40 UTC) #9
dglazkov
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1033443002/ by dglazkov@chromium.org. ...
5 years, 9 months ago (2015-03-23 15:05:18 UTC) #10
sof
With https://codereview.chromium.org/1003603004/ addressed, this can be attempted relanded, but will wait for https://codereview.chromium.org/1027333003/ also. (https://code.google.com/p/chromium/codesearch#search/&q=%5C.postMessage%5C(%5C)&sq=package:chromium&type=cs ...
5 years, 9 months ago (2015-03-24 15:19:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1025203002/20001
5 years, 9 months ago (2015-03-24 19:08:38 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 21:31:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192483

Powered by Google App Engine
This is Rietveld 408576698