Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1033443002: Revert of Have postMessage()s throw TypeError on failed arity checks. (Closed)

Created:
5 years, 9 months ago by dglazkov
Modified:
5 years, 9 months ago
Reviewers:
haraken, sof, Mike West, jsbell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Have postMessage()s throw TypeError on failed arity checks. (patchset #2 id:20001 of https://codereview.chromium.org/1025203002/) Reason for revert: Broke org.chromium.android_webview.test.PostMessageTest#testPostUnsupportedWebMessageToApp http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/4331/steps/Instrumentation%20test%20AndroidWebViewTest%20%28with%20patch%29/logs/stdio Original issue's description: > Have postMessage()s throw TypeError on failed arity checks. > > R=haraken,mkwst@chromium.org > BUG=339441 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192337 TBR=mkwst@chromium.org,haraken@chromium.org,jsbell@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=339441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -89 lines) Patch
M LayoutTests/fast/dom/Window/window-postmessage-args.html View 4 chunks +22 lines, -27 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt View 2 chunks +28 lines, -34 lines 0 comments Download
M LayoutTests/fast/events/message-port-multi-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resources/message-port-multi.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/workers/inline-worker-via-blob-url.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/workers/resources/worker-multi-port.js View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/fast/workers/resources/worker-thread-multi-port.js View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fast/workers/worker-multi-port-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/inspector/console/worker-exception-message-contains-stack.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/PostMessage.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dglazkov
Created Revert of Have postMessage()s throw TypeError on failed arity checks.
5 years, 9 months ago (2015-03-23 15:05:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1033443002/1
5 years, 9 months ago (2015-03-23 15:05:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192364
5 years, 9 months ago (2015-03-23 15:06:00 UTC) #3
haraken
LGTM
5 years, 9 months ago (2015-03-23 15:09:34 UTC) #4
sof
5 years, 9 months ago (2015-03-23 16:24:21 UTC) #5
Message was sent while issue was closed.
lgtm, thanks for reverting.

The problematic call being
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...

Powered by Google App Engine
This is Rietveld 408576698