Source/bindings/core/v8/PostMessage.h - Issue 1025203002: Have postMessage()s throw TypeError on failed arity checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/PostMessage.h

Issue 1025203002: Have postMessage()s throw TypeError on failed arity checks. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: tidy up incorrect postMessage() usage Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/console/worker-exception-message-contains-stack.html ('k') | Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/PostMessage.h

diff --git a/Source/bindings/core/v8/PostMessage.h b/Source/bindings/core/v8/PostMessage.h

index b4a381d35c5d9d723da24232182196634aabdd0e..b86a45c96a21aa340f198d4faeae8987bb13b495 100644

--- a/Source/bindings/core/v8/PostMessage.h

+++ b/Source/bindings/core/v8/PostMessage.h

@@ -23,6 +23,11 @@ template <class Type>

void postMessageMethodCommon(const char* interfaceName, Type* instance, const v8::FunctionCallbackInfo<v8::Value>& info)

{

ExceptionState exceptionState(ExceptionState::ExecutionContext, "postMessage", interfaceName, info.Holder(), info.GetIsolate());

+ if (UNLIKELY(info.Length() < 1)) {

+ setMinimumArityTypeError(exceptionState, 1, info.Length());

+ exceptionState.throwIfNeeded();

+ return;

+ }

MessagePortArray ports;

ArrayBufferArray arrayBuffers;

if (info.Length() > 1) {