chrome/chrome_browser.gypi - Issue 1024943002: Add domain request detection to incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge domain and script incidents, ignore top-level requests, improve unit tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_service.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | chrome/common/safe_browsing/csd.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index f8c985e7ed1fcb55f3e320038e76b462d2747065..07e471641453e82ddc84b946c317e7282719fbb6 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -2388,10 +2388,10 @@

'browser/safe_browsing/incident_reporting/off_domain_inclusion_detector.h',

'browser/safe_browsing/incident_reporting/preference_validation_delegate.cc',

'browser/safe_browsing/incident_reporting/preference_validation_delegate.h',

- 'browser/safe_browsing/incident_reporting/script_request_detector.cc',

- 'browser/safe_browsing/incident_reporting/script_request_detector.h',

- 'browser/safe_browsing/incident_reporting/script_request_incident.cc',

- 'browser/safe_browsing/incident_reporting/script_request_incident.h',

+ 'browser/safe_browsing/incident_reporting/resource_request_detector.cc',

+ 'browser/safe_browsing/incident_reporting/resource_request_detector.h',

+ 'browser/safe_browsing/incident_reporting/resource_request_incident.cc',

+ 'browser/safe_browsing/incident_reporting/resource_request_incident.h',

'browser/safe_browsing/incident_reporting/tracked_preference_incident.cc',

'browser/safe_browsing/incident_reporting/tracked_preference_incident.h',

'browser/safe_browsing/incident_reporting/variations_seed_signature_analyzer.cc',