Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3950)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge domain and script incidents, ignore top-level requests, improve unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index cf487918fdfe4e0d7249bcbfc6a9fc84decbeea4..eab8e4c3cfe3c6b60045469c097b522e6d173326 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -367,9 +367,15 @@ message ClientIncidentReport {
message VariationsSeedSignatureIncident {
optional string variations_seed_signature = 1;
}
- message ScriptRequestIncident {
- optional string script_digest = 1;
grt (UTC plus 2) 2015/03/27 14:17:44 I changed this from "string" to "bytes" yesterday.
romanl 2015/03/30 14:46:50 Done.
- optional string inclusion_origin = 2;
+ message ResourceRequestIncident {
+ enum Type {
+ UNKNOWN = 0;
+ TYPE_SCRIPT = 1;
+ TYPE_DOMAIN = 2;
+ }
+ optional string digest = 1;
+ optional string origin = 2;
+ optional Type type = 3;
}
optional int64 incident_time_msec = 1;
optional TrackedPreferenceIncident tracked_preference = 2;
@@ -377,7 +383,7 @@ message ClientIncidentReport {
optional BlacklistLoadIncident blacklist_load = 4;
// Note: skip tag 5 because it was previously used.
optional VariationsSeedSignatureIncident variations_seed_signature = 6;
- optional ScriptRequestIncident script_request = 7;
+ optional ResourceRequestIncident resource_request = 7;
}
repeated IncidentData incident = 1;

Powered by Google App Engine
This is Rietveld 408576698