Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge domain and script incidents, ignore top-level requests, improve unit tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc b/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc
new file mode 100644
index 0000000000000000000000000000000000000000..23c97081c7fac24e863d610ddc4412dc936c7486
--- /dev/null
+++ b/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc
@@ -0,0 +1,44 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h"
+
+#include "base/logging.h"
+#include "chrome/browser/safe_browsing/incident_reporting/incident_handler_util.h"
+#include "chrome/common/safe_browsing/csd.pb.h"
+
+namespace safe_browsing {
+
+ResourceRequestIncident::ResourceRequestIncident(
+ scoped_ptr<ClientIncidentReport_IncidentData_ResourceRequestIncident>
+ script_request_incident) {
+ DCHECK(script_request_incident);
+ DCHECK(script_request_incident->has_digest());
+ payload()->set_allocated_resource_request(script_request_incident.release());
+}
+
+ResourceRequestIncident::~ResourceRequestIncident() {
+}
+
+IncidentType ResourceRequestIncident::GetType() const {
+ return IncidentType::RESOURCE_REQUEST;
+}
+
+std::string ResourceRequestIncident::GetKey() const {
+ // Use a static key in addition to a fixed digest below to ensure that only
grt (UTC plus 2) 2015/03/27 14:17:43 please update the comment: // Use a static key p
romanl 2015/03/30 14:46:50 Done.
+ // one incident per user (and incident type) is reported.
+ return payload()->resource_request().type() ==
+ ClientIncidentReport_IncidentData_ResourceRequestIncident::
+ TYPE_SCRIPT
+ ? "script_request_incident"
+ : "domain_request_incident";
+}
+
+uint32_t ResourceRequestIncident::ComputeDigest() const {
+ // Return a constant in addition to a fixed key above to ensure that only one
grt (UTC plus 2) 2015/03/27 14:17:43 // Return a constant in addition to a fixed key pe
romanl 2015/03/30 14:46:50 Done.
+ // incident per user is reported.
+ return 42;
+}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698