chrome/browser/safe_browsing/safe_browsing_service.h - Issue 1024943002: Add domain request detection to incident reporting service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1024943002: Add domain request detection to incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge domain and script incidents, ignore top-level requests, improve unit tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/script_request_incident.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | chrome/common/safe_browsing/csd.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h

index 6eb7e2177e750d9cf66d285a6c0ece3ef1e3a640..5720e004fcea2f082dccc4613ab81524f2d568f0 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.h

+++ b/chrome/browser/safe_browsing/safe_browsing_service.h

@@ -59,7 +59,7 @@ class DownloadProtectionService;

#if defined(FULL_SAFE_BROWSING)

class IncidentReportingService;

class OffDomainInclusionDetector;

-class ScriptRequestDetector;

+class ResourceRequestDetector;

#endif

}

@@ -269,7 +269,7 @@ class SafeBrowsingService

scoped_ptr<safe_browsing::OffDomainInclusionDetector>

off_domain_inclusion_detector_;

- scoped_ptr<safe_browsing::ScriptRequestDetector> script_request_detector_;

+ scoped_ptr<safe_browsing::ResourceRequestDetector> resource_request_detector_;

#endif

DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);