Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1753)

Issue 1024713002: Drop Big5-HKSCS and add IBM866 in the encoding menu. (Closed)

Created:
5 years, 9 months ago by jungshik at Google
Modified:
5 years, 9 months ago
Reviewers:
jsbell, sky
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop Big5-HKSCS and add IBM866 in the encoding menu. The HTML encoding spec unified Big5 and Big5-HKSCS and we're not distinguishing them any more. The spec also has IBM866 that is not in the menu, yet. BUG=None TEST=manual: 1. load a page in ibm866 and check the encoding in More Tools|Encoding. 2. load pages labelled as in Big5 and Big5-HKSCS and check the encoding. TEST=browser_tests --gtest_filter=*ncodin* TEST=unit_tests --gtest_filter EncodingMenu* Committed: https://crrev.com/03456dca25a19f8b445321ba5531b6693883cda5 Cr-Commit-Position: refs/heads/master@{#322068}

Patch Set 1 #

Patch Set 2 : add ibm866 #

Total comments: 2

Patch Set 3 : remove holes in IDC ids #

Patch Set 4 : fix EncodingMenuControllerTest.EncodingIDsBelongTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M chrome/app/chrome_command_ids.h View 1 2 1 chunk +34 lines, -34 lines 0 comments Download
M chrome/browser/character_encoding.cc View 1 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/encoding_menu_controller.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
jungshik at Google
5 years, 9 months ago (2015-03-20 22:56:16 UTC) #2
jungshik at Google
sky@chromium.org: PTAL for owner approval. jsbell: PTAL at the encoding menu changes. Thanks
5 years, 9 months ago (2015-03-20 22:58:54 UTC) #4
jsbell
lgtm
5 years, 9 months ago (2015-03-20 23:49:18 UTC) #5
sky
https://codereview.chromium.org/1024713002/diff/20001/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/1024713002/diff/20001/chrome/app/chrome_command_ids.h#newcode101 chrome/app/chrome_command_ids.h:101: #define IDC_ENCODING_KOREAN 35509 Is there a reason you don't ...
5 years, 9 months ago (2015-03-21 16:07:56 UTC) #6
jungshik at Google
https://codereview.chromium.org/1024713002/diff/20001/chrome/app/chrome_command_ids.h File chrome/app/chrome_command_ids.h (right): https://codereview.chromium.org/1024713002/diff/20001/chrome/app/chrome_command_ids.h#newcode101 chrome/app/chrome_command_ids.h:101: #define IDC_ENCODING_KOREAN 35509 On 2015/03/21 16:07:56, sky wrote: > ...
5 years, 9 months ago (2015-03-23 19:36:17 UTC) #7
sky
LGTM
5 years, 9 months ago (2015-03-23 19:55:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024713002/40001
5 years, 9 months ago (2015-03-24 00:17:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/770)
5 years, 9 months ago (2015-03-24 01:08:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024713002/60001
5 years, 9 months ago (2015-03-24 19:55:07 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-24 20:54:18 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 20:54:49 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/03456dca25a19f8b445321ba5531b6693883cda5
Cr-Commit-Position: refs/heads/master@{#322068}

Powered by Google App Engine
This is Rietveld 408576698