chrome/browser/ui/toolbar/encoding_menu_controller.cc - Issue 1024713002: Drop Big5-HKSCS and add IBM866 in the encoding menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/encoding_menu_controller.cc

Issue 1024713002: Drop Big5-HKSCS and add IBM866 in the encoding menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix EncodingMenuControllerTest.EncodingIDsBelongTest Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/toolbar/encoding_menu_controller.cc

diff --git a/chrome/browser/ui/toolbar/encoding_menu_controller.cc b/chrome/browser/ui/toolbar/encoding_menu_controller.cc

index 8d9089c75deb2c9d11f76e7ab5acfba3dd5300fb..0f4a8217123270248c3d50cb0a877e28be158d8f 100644

--- a/chrome/browser/ui/toolbar/encoding_menu_controller.cc

+++ b/chrome/browser/ui/toolbar/encoding_menu_controller.cc

@@ -22,7 +22,6 @@ const int EncodingMenuController::kValidEncodingIds[] = {

IDC_ENCODING_GBK,

IDC_ENCODING_GB18030,

IDC_ENCODING_BIG5,

- IDC_ENCODING_BIG5HKSCS,

IDC_ENCODING_KOREAN,

IDC_ENCODING_SHIFTJIS,

IDC_ENCODING_ISO2022JP,

@@ -52,6 +51,7 @@ const int EncodingMenuController::kValidEncodingIds[] = {

IDC_ENCODING_WINDOWS1255,

IDC_ENCODING_WINDOWS1258,

IDC_ENCODING_ISO88598I,

+ IDC_ENCODING_IBM866,

};

bool EncodingMenuController::DoesCommandBelongToEncodingMenu(int id) {

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »