Drop Big5-HKSCS and add IBM866 in the encoding menu.

chrome/app/chrome_command_ids.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_APP_CHROME_COMMAND_IDS_H_
 #define CHROME_APP_CHROME_COMMAND_IDS_H_
 
 // This file lists all the command IDs understood by e.g. the browser.
 // It is used by Windows RC files, Mac NIB files, and other platforms too.
 
@@ skipping 80 matching lines @@
 // When adding a new encoding to this list, be sure to append it to the
 // EncodingMenuController::kValidEncodingIds array in
 // encoding_menu_controller.cc.
 #define IDC_ENCODING_AUTO_DETECT        35500
 #define IDC_ENCODING_UTF8               35501
 #define IDC_ENCODING_UTF16LE            35502
 #define IDC_ENCODING_WINDOWS1252        35504
 #define IDC_ENCODING_GBK                35505
 #define IDC_ENCODING_GB18030            35506
 #define IDC_ENCODING_BIG5               35507
-#define IDC_ENCODING_BIG5HKSCS          35508
 #define IDC_ENCODING_KOREAN             35509

[sky, 2015/03/21 16:07:56]

Is there a reason you don't want adjust subsequent commands so we don't have any
holes?

[jungshik at Google, 2015/03/23 19:36:17]

Initially, I thought that it'd lower the chance of a profile "conflict" between
versions, but it should not matter because the preferred encoding is stored as a
string (if somebody sets it to Big5HKSCS, which is very unlikely).  

I'll just remove the holes (there's one more hole created when removing
ISO-8859-1). 

 #define IDC_ENCODING_SHIFTJIS           35510
 #define IDC_ENCODING_ISO2022JP          35511
 #define IDC_ENCODING_EUCJP              35512
 #define IDC_ENCODING_THAI               35513
 #define IDC_ENCODING_ISO885915          35514
 #define IDC_ENCODING_MACINTOSH          35515
 #define IDC_ENCODING_ISO88592           35516
 #define IDC_ENCODING_WINDOWS1250        35517
 #define IDC_ENCODING_ISO88595           35518
 #define IDC_ENCODING_WINDOWS1251        35519
 #define IDC_ENCODING_KOI8R              35520
 #define IDC_ENCODING_KOI8U              35521
 #define IDC_ENCODING_ISO88597           35522
 #define IDC_ENCODING_WINDOWS1253        35523
 #define IDC_ENCODING_ISO88594           35524
 #define IDC_ENCODING_ISO885913          35525
 #define IDC_ENCODING_WINDOWS1257        35526
 #define IDC_ENCODING_ISO88593           35527
 #define IDC_ENCODING_ISO885910          35528
 #define IDC_ENCODING_ISO885914          35529
 #define IDC_ENCODING_ISO885916          35530
 #define IDC_ENCODING_WINDOWS1254        35531
 #define IDC_ENCODING_ISO88596           35532
 #define IDC_ENCODING_WINDOWS1256        35533
 #define IDC_ENCODING_ISO88598           35534
 #define IDC_ENCODING_WINDOWS1255        35535
 #define IDC_ENCODING_WINDOWS1258        35536
 #define IDC_ENCODING_ISO88598I          35537
+#define IDC_ENCODING_IBM866             35538
 
 // Clipboard commands
 #define IDC_CUT                         36000
 #define IDC_COPY                        36001
 #define IDC_PASTE                       36003
 #define IDC_EDIT_MENU                   36004
 
 // Find-in-page
 #define IDC_FIND                        37000
 #define IDC_FIND_NEXT                   37001
@@ skipping 213 matching lines @@
 
 // Protocol handler menu entries
 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST     52000
 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST      52199
 #define IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_SETTINGS  52200
 
 // NOTE: The last valid command value is 57343 (0xDFFF)
 // See http://msdn.microsoft.com/en-us/library/t2zechd4(VS.71).aspx
 
 #endif  // CHROME_APP_CHROME_COMMAND_IDS_H_