Add cookies' first-partyness to chrome://settings/cookies

chrome/browser/ui/views/cookie_info_view.cc

Index: chrome/browser/ui/views/cookie_info_view.cc
diff --git a/chrome/browser/ui/views/cookie_info_view.cc b/chrome/browser/ui/views/cookie_info_view.cc
index a22f30257566f90cf3ac79fba4442523a3f4469e..9f157587071c48a89c6bf0222750e6e2027329e3 100644
--- a/chrome/browser/ui/views/cookie_info_view.cc
+++ b/chrome/browser/ui/views/cookie_info_view.cc
@@ -63,9 +63,13 @@ void CookieInfoView::SetCookie(const std::string& domain,
       l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_EXPIRES_SESSION);
 
   expires_value_field_->SetText(expire_text);
-  send_for_value_field_->SetText(cookie.IsSecure() ?
-      l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_SECURE) :
-      l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_ANY));
+  send_for_value_field_->SetText(l10n_util::GetStringUTF16(
+      cookie.IsSecure()
+          ? cookie.IsFirstPartyOnly()
+                ? IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY
+                : IDS_COOKIES_COOKIE_SENDFOR_SECURE
+          : cookie.IsFirstPartyOnly() ? IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY
+                                      : IDS_COOKIES_COOKIE_SENDFOR_ANY));

[Pam (message me for reviews), 2015/03/20 10:30:38]

Oh dear. There aren't any really great solutions here, but this is really hard
to read. I'd suggest one if-then split, i.e.

if (cookie.IsSecure()) {
  cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY :
      COOKIE_SENDFOR_SECURE;
} else {
 cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY :
      COOKIE_SENDFOR_ANY;
}

   EnableCookieDisplay(true);
   Layout();
 }