Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/ui/webui/cookies_tree_model_util.cc

Issue 1024503002: Add cookies' first-partyness to chrome://settings/cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/cookies_tree_model_util.cc
diff --git a/chrome/browser/ui/webui/cookies_tree_model_util.cc b/chrome/browser/ui/webui/cookies_tree_model_util.cc
index 24de43691f0e5b80c56b1ff669ded38d145037a8..712973a6dec34a59fb3383f2f3aa95c79eb5dd84 100644
--- a/chrome/browser/ui/webui/cookies_tree_model_util.cc
+++ b/chrome/browser/ui/webui/cookies_tree_model_util.cc
@@ -125,9 +125,16 @@ bool CookiesTreeModelUtil::GetCookieTreeNodeDictionary(
dict->SetString(kKeyContent, cookie.Value());
dict->SetString(kKeyDomain, cookie.Domain());
dict->SetString(kKeyPath, cookie.Path());
- dict->SetString(kKeySendFor, cookie.IsSecure() ?
- l10n_util::GetStringUTF8(IDS_COOKIES_COOKIE_SENDFOR_SECURE) :
- l10n_util::GetStringUTF8(IDS_COOKIES_COOKIE_SENDFOR_ANY));
+ dict->SetString(
+ kKeySendFor,
+ l10n_util::GetStringUTF16(
+ cookie.IsSecure()
+ ? cookie.IsFirstPartyOnly()
+ ? IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY
+ : IDS_COOKIES_COOKIE_SENDFOR_SECURE
+ : cookie.IsFirstPartyOnly()
+ ? IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY
+ : IDS_COOKIES_COOKIE_SENDFOR_ANY));
Pam (message me for reviews) 2015/03/20 10:30:39 same here, more so
std::string accessible = cookie.IsHttpOnly() ?
l10n_util::GetStringUTF8(IDS_COOKIES_COOKIE_ACCESSIBLE_TO_SCRIPT_NO) :
l10n_util::GetStringUTF8(IDS_COOKIES_COOKIE_ACCESSIBLE_TO_SCRIPT_YES);
« chrome/browser/ui/views/cookie_info_view.cc ('K') | « chrome/browser/ui/views/cookie_info_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698