Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1024473004: Do not treat '0' as 'none' for font-size-adjust (Closed)

Created:
5 years, 9 months ago by changseok
Modified:
5 years, 9 months ago
Reviewers:
dstockwell, eae, rune
CC:
dstockwell, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-rendering, blink-reviews-style_chromium.org, Rik, danakj, dglazkov+blink, Dominik Röttsches, dshwang, krit, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, Mike Lawther (Google), pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not treat '0' as 'none' for font-size-adjust Current implementation for font-size-adjust has followed gecko's behavior. However we could know it's a gecko's bug after discussion with CSSWG[1]. This cl will fix the behavior for '0' not being same with 'none'. [1] https://lists.w3.org/Archives/Public/www-style/2015Mar/0331.html BUG=468236, 451346 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192383

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Total comments: 2

Patch Set 3 : Removed an empty line. #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M LayoutTests/animations/interpolation/font-size-adjust-interpolation.html View 2 chunks +8 lines, -8 lines 0 comments Download
M LayoutTests/animations/interpolation/font-size-adjust-interpolation-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/layout/style/LayoutStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 4 chunks +5 lines, -2 lines 0 comments Download
M Source/platform/fonts/FontDescription.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
changseok
PTAL
5 years, 9 months ago (2015-03-19 16:08:17 UTC) #2
dstockwell
https://codereview.chromium.org/1024473004/diff/1/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1024473004/diff/1/Source/core/animation/StringKeyframe.cpp#newcode234 Source/core/animation/StringKeyframe.cpp:234: // FIXME: Handle keywords e.g. 'none'. This shouldn't be ...
5 years, 9 months ago (2015-03-20 03:24:29 UTC) #3
changseok
Thanks for your review. https://codereview.chromium.org/1024473004/diff/1/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1024473004/diff/1/Source/core/animation/StringKeyframe.cpp#newcode234 Source/core/animation/StringKeyframe.cpp:234: // FIXME: Handle keywords e.g. ...
5 years, 9 months ago (2015-03-20 08:29:40 UTC) #4
changseok
More comments?
5 years, 9 months ago (2015-03-22 07:20:36 UTC) #5
dstockwell
lgtm https://codereview.chromium.org/1024473004/diff/20001/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1024473004/diff/20001/Source/core/animation/StringKeyframe.cpp#newcode233 Source/core/animation/StringKeyframe.cpp:233: Nit. extra blank line.
5 years, 9 months ago (2015-03-22 22:51:04 UTC) #6
changseok
Thanks! https://codereview.chromium.org/1024473004/diff/20001/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/1024473004/diff/20001/Source/core/animation/StringKeyframe.cpp#newcode233 Source/core/animation/StringKeyframe.cpp:233: On 2015/03/22 22:51:04, dstockwell wrote: > Nit. extra ...
5 years, 9 months ago (2015-03-23 02:51:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024473004/40001
5 years, 9 months ago (2015-03-23 02:53:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/29540)
5 years, 9 months ago (2015-03-23 03:00:20 UTC) #12
changseok
On 2015/03/23 03:00:20, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-23 03:13:01 UTC) #13
rune
On 2015/03/23 03:13:01, changseok wrote: > On 2015/03/23 03:00:20, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-23 07:51:41 UTC) #14
changseok
> I'm not an owner of platform. Pick a reviewer from Source/platform/OWNERS. Since > this ...
5 years, 9 months ago (2015-03-23 07:58:44 UTC) #16
eae
LGTM
5 years, 9 months ago (2015-03-23 17:18:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024473004/60001
5 years, 9 months ago (2015-03-23 17:21:53 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 20:28:26 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192383

Powered by Google App Engine
This is Rietveld 408576698