Do not treat '0' as 'none' for font-size-adjust

Source/platform/fonts/FontDescription.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 29 matching lines @@
 #include "wtf/MathExtras.h"
 
 #include "wtf/RefPtr.h"
 
 #include <unicode/uscript.h>
 
 namespace blink {
 
 class PLATFORM_EXPORT FontDescription {
 public:
+    enum SizeAdjust { SizeAdjustNone = -1 };

[dstockwell, 2015/03/20 03:24:29]

This should be a const, not an enum.

[changseok, 2015/03/20 08:29:39]

Done.

     enum GenericFamilyType { NoFamily, StandardFamily, SerifFamily, SansSerifFamily,
                              MonospaceFamily, CursiveFamily, FantasyFamily, PictographFamily };
 
     enum Kerning { AutoKerning, NormalKerning, NoneKerning };
 
     enum LigaturesState { NormalLigaturesState, DisabledLigaturesState, EnabledLigaturesState };
 
     FontDescription()
         : m_specifiedSize(0)
         , m_computedSize(0)
         , m_adjustedSize(0)
-        , m_sizeAdjust(0)
+        , m_sizeAdjust(SizeAdjustNone)
         , m_letterSpacing(0)
         , m_wordSpacing(0)
         , m_orientation(Horizontal)
         , m_nonCJKGlyphOrientation(NonCJKGlyphOrientationVerticalRight)
         , m_widthVariant(RegularWidth)
         , m_style(FontStyleNormal)
         , m_variant(FontVariantNormal)
         , m_isAbsoluteSize(false)
         , m_weight(FontWeightNormal)
         , m_stretch(FontStretchNormal)
@@ skipping 56 matching lines @@
     };
 
     const FontFamily& family() const { return m_familyList; }
     FamilyDescription familyDescription() const { return FamilyDescription(genericFamily(), family()); }
     FontFamily& firstFamily() { return m_familyList; }
     Size size() const { return Size(m_keywordSize, m_specifiedSize, m_isAbsoluteSize); }
     float specifiedSize() const { return m_specifiedSize; }
     float computedSize() const { return m_computedSize; }
     float adjustedSize() const { return m_adjustedSize; }
     float sizeAdjust() const { return m_sizeAdjust; }
+    bool hasSizeAdjust() const { return m_sizeAdjust >= 0; }

[dstockwell, 2015/03/20 03:24:29]

Should be != SizeAdjustNone.

[changseok, 2015/03/20 08:29:39]

Done.

     FontStyle style() const { return static_cast<FontStyle>(m_style); }
     int computedPixelSize() const { return int(m_computedSize + 0.5f); }
     FontVariant variant() const { return static_cast<FontVariant>(m_variant); }
     bool isAbsoluteSize() const { return m_isAbsoluteSize; }
     FontWeight weight() const { return static_cast<FontWeight>(m_weight); }
     FontStretch stretch() const { return static_cast<FontStretch>(m_stretch); }
     static FontWeight lighterWeight(FontWeight);
     static FontWeight bolderWeight(FontWeight);
     static Size largerSize(const Size&);
     static Size smallerSize(const Size&);
@@ skipping 157 matching lines @@
         && m_script == other.m_script
         && m_syntheticBold == other.m_syntheticBold
         && m_syntheticItalic == other.m_syntheticItalic
         && m_featureSettings == other.m_featureSettings
         && m_subpixelTextPosition == other.m_subpixelTextPosition;
 }
 
 } // namespace blink
 
 #endif