Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1024423002: Turn the InspectorHighlight builder into a stack allocated object. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Turn the InspectorHighlight builder into a stack allocated object. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -82 lines) Patch
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.h View 2 chunks +8 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorHighlight.cpp View 3 chunks +59 lines, -61 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
please take a look. following up on https://codereview.chromium.org/1008083003/#msg4
5 years, 9 months ago (2015-03-23 13:37:39 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-23 13:38:55 UTC) #3
pfeldman
Please explain why this is happening.
5 years, 9 months ago (2015-03-23 14:24:27 UTC) #4
pfeldman
Ah, this is a good one, not the heap allocated! lgtm
5 years, 9 months ago (2015-03-23 14:25:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024423002/1
5 years, 9 months ago (2015-03-23 16:40:07 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:12:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192387

Powered by Google App Engine
This is Rietveld 408576698