Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/core/inspector/InspectorHighlight.h

Issue 1024423002: Turn the InspectorHighlight builder into a stack allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorHighlight.h
diff --git a/Source/core/inspector/InspectorHighlight.h b/Source/core/inspector/InspectorHighlight.h
index 982e3b2db9d31b29798e0e2610b87f6a0b5551bf..e6fa60ca5f2349cec05a1d6d261ba00f79ec09f7 100644
--- a/Source/core/inspector/InspectorHighlight.h
+++ b/Source/core/inspector/InspectorHighlight.h
@@ -33,16 +33,13 @@ public:
bool showExtensionLines;
};
-class InspectorHighlight : public NoBaseWillBeGarbageCollectedFinalized<InspectorHighlight> {
+class InspectorHighlight {
+ STACK_ALLOCATED();
public:
+ InspectorHighlight(Node*, const InspectorHighlightConfig&, bool appendElementInfo);
+ InspectorHighlight();
~InspectorHighlight();
- static PassOwnPtrWillBeRawPtr<InspectorHighlight> create(Node*, const InspectorHighlightConfig&, bool appendElementInfo);
- static PassOwnPtrWillBeRawPtr<InspectorHighlight> create()
- {
- return adoptPtrWillBeNoop(new InspectorHighlight());
- }
-
static bool getBoxModel(Node*, RefPtr<TypeBuilder::DOM::BoxModel>&);
static InspectorHighlightConfig defaultConfig();
@@ -51,18 +48,16 @@ public:
void appendEventTargetQuads(Node* eventTargetNode, const InspectorHighlightConfig&);
PassRefPtr<JSONObject> asJSONObject() const;
- DEFINE_INLINE_TRACE() { }
-
private:
- InspectorHighlight();
+ void appendNodeHighlight(Node*, const InspectorHighlightConfig&);
+ void appendPathsForShapeOutside(Node*, const InspectorHighlightConfig&);
- bool m_showRulers;
- bool m_showExtensionLines;
RefPtr<JSONObject> m_elementInfo;
RefPtr<JSONArray> m_highlightPaths;
+ bool m_showRulers;
+ bool m_showExtensionLines;
};
} // namespace blink
-
#endif // InspectorHighlight_h
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698