Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: Source/web/InspectorOverlayImpl.cpp

Issue 1024423002: Turn the InspectorHighlight builder into a stack allocated object. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorHighlight.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/InspectorOverlayImpl.cpp
diff --git a/Source/web/InspectorOverlayImpl.cpp b/Source/web/InspectorOverlayImpl.cpp
index 6961378c91c05cd17f47f51808316e6cc47ad5f0..fff8ea73a2704cee6fcc9b3c36ffb0f21005ad3b 100644
--- a/Source/web/InspectorOverlayImpl.cpp
+++ b/Source/web/InspectorOverlayImpl.cpp
@@ -273,10 +273,10 @@ void InspectorOverlayImpl::drawNodeHighlight()
return;
bool appendElementInfo = m_highlightNode->isElementNode() && !m_omitTooltip && m_nodeHighlightConfig.showInfo && m_highlightNode->layoutObject() && m_highlightNode->document().frame();
- OwnPtrWillBeRawPtr<InspectorHighlight> highlight = InspectorHighlight::create(m_highlightNode.get(), m_nodeHighlightConfig, appendElementInfo);
+ InspectorHighlight highlight(m_highlightNode.get(), m_nodeHighlightConfig, appendElementInfo);
if (m_eventTargetNode)
- highlight->appendEventTargetQuads(m_eventTargetNode.get(), m_nodeHighlightConfig);
- evaluateInOverlay("drawHighlight", highlight->asJSONObject());
+ highlight.appendEventTargetQuads(m_eventTargetNode.get(), m_nodeHighlightConfig);
+ evaluateInOverlay("drawHighlight", highlight.asJSONObject());
}
void InspectorOverlayImpl::drawQuadHighlight()
@@ -284,9 +284,9 @@ void InspectorOverlayImpl::drawQuadHighlight()
if (!m_highlightQuad)
return;
- OwnPtrWillBeRawPtr<InspectorHighlight> highlight = InspectorHighlight::create();
- highlight->appendQuad(*m_highlightQuad, m_quadHighlightConfig.content, m_quadHighlightConfig.contentOutline);
- evaluateInOverlay("drawHighlight", highlight->asJSONObject());
+ InspectorHighlight highlight;
+ highlight.appendQuad(*m_highlightQuad, m_quadHighlightConfig.content, m_quadHighlightConfig.contentOutline);
+ evaluateInOverlay("drawHighlight", highlight.asJSONObject());
}
void InspectorOverlayImpl::drawPausedInDebuggerMessage()
« no previous file with comments | « Source/core/inspector/InspectorHighlight.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698