content/browser/frame_host/navigation_controller_android.cc - Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_android.cc

Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments and build fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_android.cc

diff --git a/content/browser/frame_host/navigation_controller_android.cc b/content/browser/frame_host/navigation_controller_android.cc

index 3b3d4928159b017cd2e84474b71a665340976c20..4820dc074d6dd567b15d417e91c8596afa204a88 100644

--- a/content/browser/frame_host/navigation_controller_android.cc

+++ b/content/browser/frame_host/navigation_controller_android.cc

@@ -49,7 +49,8 @@ static base::android::ScopedJavaLocalRef<jobject> CreateJavaNavigationEntry(

j_virtual_url.obj(),

j_original_url.obj(),

j_title.obj(),

- j_bitmap.obj());

+ j_bitmap.obj(),

+ entry->GetTransitionType());

}

static void AddNavigationEntryToHistory(JNIEnv* env,