Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1024073003: Treat Object and dynamic similarly (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 9 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Treat Object and dynamic similarly Note, this makes: T<dynamic> <: T<Object> and T<Object> <: T<dynamic>. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d21e8be37291ac52bb44caccac1475a44d3413b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -57 lines) Patch
M lib/runtime/dart/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/checker/rules.dart View 4 chunks +33 lines, -13 lines 0 comments Download
M test/checker/checker_test.dart View 3 chunks +8 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/collection/set.dart View 1 chunk +2 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/convert/latin1.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/convert/string_conversion.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 9 months ago (2015-03-20 20:32:42 UTC) #2
Leaf
lgtm nice. lgtm!
5 years, 9 months ago (2015-03-20 20:50:42 UTC) #3
vsm
5 years, 9 months ago (2015-03-20 21:06:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d21e8be37291ac52bb44caccac1475a44d3413b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698