lib/runtime/dart/collection.js - Issue 1024073003: Treat Object and dynamic similarly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/collection.js

Issue 1024073003: Treat Object and dynamic similarly (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart/collection.js

diff --git a/lib/runtime/dart/collection.js b/lib/runtime/dart/collection.js

index 7f7cf83c84aec82dbce4f3faa16527cdb8365f98..a4e55a83d465a5ddaabe3e79fa3d681a4f684fce 100644

--- a/lib/runtime/dart/collection.js

+++ b/lib/runtime/dart/collection.js

@@ -119,7 +119,7 @@ var collection;

if (test(element))

toRemove.add(element);

}

- this.removeAll(dart.as(toRemove, core.Iterable$(core.Object)));

+ this.removeAll(toRemove);

}

retainWhere(test) {

let toRemove = new List.from([]);

@@ -127,7 +127,7 @@ var collection;

if (!dart.notNull(test(element)))

toRemove.add(element);

}

- this.removeAll(dart.as(toRemove, core.Iterable$(core.Object)));

+ this.removeAll(toRemove);

}

containsAll(other) {

for (let o of other) {

« no previous file with comments | « no previous file | lib/runtime/dart/convert.js » ('j') | no next file with comments »