Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: test/checker/checker_test.dart

Issue 1024073003: Treat Object and dynamic similarly (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/rules.dart ('k') | test/dart_codegen/expect/collection/set.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/checker/checker_test.dart
diff --git a/test/checker/checker_test.dart b/test/checker/checker_test.dart
index 0377b71b94a02382a761722f4e3322e9e585985a..8bd958fd1df0bde3e50125b406de71bda5a6893c 100644
--- a/test/checker/checker_test.dart
+++ b/test/checker/checker_test.dart
@@ -1409,17 +1409,13 @@ void main() {
class L<T> {}
class M<T> extends L<T> {}
- // L<dynamic>
- // / \
- // M<dynamic> L<Object>
- // | / /
- // M<Object> L<A>
- // \ /
- // M<A>
+ // L<dynamic|Object>
+ // / \
+ // M<dynamic|Object> L<A>
+ // \ /
+ // M<A>
// In normal Dart, there are additional edges
// from M<A> to M<dynamic>
- // from L<Object> to M<dynamic>
- // from L<Object> to L<dynamic>
// from L<A> to M<dynamic>
// from L<A> to L<dynamic>
void main() {
@@ -1440,10 +1436,10 @@ void main() {
lOfDs = lOfAs;
}
{
- lOfOs = /*warning:DownCastDynamic*/mOfDs;
+ lOfOs = mOfDs;
lOfOs = mOfOs;
lOfOs = mOfAs;
- lOfOs = /*warning:DownCastDynamic*/lOfDs;
+ lOfOs = lOfDs;
lOfOs = lOfOs;
lOfOs = lOfAs;
}
@@ -1464,7 +1460,7 @@ void main() {
mOfDs = /*info:DownCast*/lOfAs;
}
{
- mOfOs = /*warning:DownCastDynamic*/mOfDs;
+ mOfOs = mOfDs;
mOfOs = mOfOs;
mOfOs = mOfAs;
mOfOs = /*info:DownCast*/lOfDs;
« no previous file with comments | « lib/src/checker/rules.dart ('k') | test/dart_codegen/expect/collection/set.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698