Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 1023673009: Adding Mojo C thunks headers to be used by html_viewer. Note that the Mojo shell can register an im… (Closed)

Created:
5 years, 9 months ago by alhaad
Modified:
5 years, 9 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Mojo C thunks headers to be used by html_viewer. Note that the Mojo shell can register an implementation only when this is rolled into the Mojo repo. R=jamesr@chromium.org,piman@chromium.org BUG=453591 Committed: https://crrev.com/e439dcc7c72214aeac22f9db81674b05b7f5af52 Cr-Commit-Position: refs/heads/master@{#321899}

Patch Set 1 #

Patch Set 2 : Removed remnants of other cl. #

Patch Set 3 : Removing changes to third_party/mojo/* from patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2834 lines, -2823 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 9 chunks +19 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +601 lines, -606 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +2214 lines, -2214 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alhaad
5 years, 9 months ago (2015-03-23 21:55:42 UTC) #1
piman
lgtm
5 years, 9 months ago (2015-03-23 22:16:17 UTC) #2
jamesr
The headers lgtm, but the generated files should probably only exist in the mojo repo ...
5 years, 9 months ago (2015-03-23 22:45:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023673009/40001
5 years, 9 months ago (2015-03-23 23:02:27 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 23:48:40 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 23:50:13 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e439dcc7c72214aeac22f9db81674b05b7f5af52
Cr-Commit-Position: refs/heads/master@{#321899}

Powered by Google App Engine
This is Rietveld 408576698