chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 1022843003: New smart passsword bubble algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1022843003: New smart passsword bubble algorithm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle 'Never' correctly Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index bbc7c14eee211c763cc3dfb86ee12600ae46ff0d..18e45d9d5a5a57ad746c4af7673be105bba08a4e 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -332,10 +332,7 @@ void ManagePasswordsUIController::ShowBubbleWithoutUserInteraction() {

Browser* browser = chrome::FindBrowserWithWebContents(web_contents());

if (!browser || browser->toolbar_model()->input_in_progress())

return;

- if (state() == password_manager::ui::PENDING_PASSWORD_STATE &&

- !password_bubble_experiment::ShouldShowBubble(

- browser->profile()->GetPrefs()))

- return;

CommandUpdater* updater = browser->command_controller()->command_updater();

updater->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);

#endif