| Index: chrome/browser/ui/passwords/password_bubble_experiment.h
|
| diff --git a/chrome/browser/ui/passwords/password_bubble_experiment.h b/chrome/browser/ui/passwords/password_bubble_experiment.h
|
| index 9c4d30272df0f8c84b14c8cb6b63ff4e3c76db1a..eca144bdba2ef3ba3bc64442361df9f4ca65808c 100644
|
| --- a/chrome/browser/ui/passwords/password_bubble_experiment.h
|
| +++ b/chrome/browser/ui/passwords/password_bubble_experiment.h
|
| @@ -15,15 +15,15 @@ class PrefRegistrySyncable;
|
| class PrefService;
|
|
|
| // These functions handle the algorithms according to which the "Save password?"
|
| -// bubble is shown to user.
|
| +// bubble shows "No thanks" or "Never for this site" button default.
|
| namespace password_bubble_experiment {
|
|
|
| void RegisterPrefs(user_prefs::PrefRegistrySyncable* registry);
|
|
|
| -// The decision is made based on the "PasswordBubbleAlgorithm" finch experiment.
|
| -// The default value is true.
|
| +// Returns true if "Never for this site" should be the default negative option.
|
| +// Otherwise it's "No thanks". The default value is false.
|
| // It should be called before showing the "Save Password?" dialog.
|
| -bool ShouldShowBubble(PrefService* prefs);
|
| +bool ShouldShowNeverForThisSiteDefault(PrefService* prefs);
|
|
|
| // Should be called when user dismisses the "Save Password?" dialog. It stores
|
| // the statistics about interactions with the bubble.
|
| @@ -34,23 +34,9 @@ void RecordBubbleClosed(
|
| // The name of the finch experiment controlling the algorithm.
|
| extern const char kExperimentName[];
|
|
|
| -// The group name for the time based algorithm.
|
| -extern const char kGroupTimeSpanBased[];
|
| -
|
| -// The group name for the probability algorithm.
|
| -extern const char kGroupProbabilityBased[];
|
| -
|
| -// For "Probability" group. The additional "Saves" to be added to the model.
|
| -extern const char kParamProbabilityFakeSaves[];
|
| -
|
| -// For "Probability" group. The interaction history length.
|
| -extern const char kParamProbabilityInteractionsCount[];
|
| -
|
| -// For "TimeSpan" group. The time span until the nope counter is zeroed.
|
| -extern const char kParamTimeSpan[];
|
| -
|
| -// For "TimeSpan" group. The nopes threshold.
|
| -extern const char kParamTimeSpanNopeThreshold[];
|
| +// The name of the finch parameter. It signifies the consecutive nopes
|
| +// threshold after which the user sees "Never for this site" button by default.
|
| +extern const char kParamNopeThreshold[];
|
|
|
| } // namespace password_bubble_experiment
|
|
|
|
|