chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 1022843003: New smart passsword bubble algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1022843003: New smart passsword bubble algorithm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: handle 'Never' correctly Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 5233f82c4b3373a76ceffb434fb03be40242d807..1d6f9a2cab44e925738da098a87d7ace3509d6ea 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -273,7 +273,6 @@ void ManagePasswordsBubbleModel::OnChooseCredentials(

const autofill::PasswordForm& password_form,

password_manager::CredentialType credential_type) {

dismissal_reason_ = metrics_util::CLICKED_CREDENTIAL;

- RecordExperimentStatistics(web_contents(), dismissal_reason_);

ManagePasswordsUIController* manage_passwords_ui_controller =

ManagePasswordsUIController::FromWebContents(web_contents());

manage_passwords_ui_controller->ChooseCredential(password_form,