Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1022663002: Add crashpad_database_util and its man page (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Simplify error handling for --show-report #

Patch Set 3 : 2015 #

Total comments: 4

Patch Set 4 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -12 lines) Patch
M client/crash_report_database_mac.mm View 1 chunk +5 lines, -5 lines 0 comments Download
M client/crash_report_database_test.cc View 4 chunks +6 lines, -1 line 0 comments Download
M handler/mac/crashpad_handler.ad View 1 chunk +1 line, -0 lines 0 comments Download
M handler/mac/main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A tools/crashpad_database_util.ad View 1 chunk +151 lines, -0 lines 0 comments Download
A tools/crashpad_database_util.cc View 1 2 3 1 chunk +516 lines, -0 lines 0 comments Download
M tools/generate_dump.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/catch_exception_tool.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/exception_port_tool.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/on_demand_service_tool.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/mac/run_with_crashpad.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/tools.gyp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-18 22:35:09 UTC) #2
Robert Sesek
https://codereview.chromium.org/1022663002/diff/40001/tools/crashpad_database_util.cc File tools/crashpad_database_util.cc (right): https://codereview.chromium.org/1022663002/diff/40001/tools/crashpad_database_util.cc#newcode84 tools/crashpad_database_util.cc:84: bool StringToBool(const char* string, bool* boolean) { It would ...
5 years, 9 months ago (2015-03-19 21:00:58 UTC) #3
Mark Mentovai
https://codereview.chromium.org/1022663002/diff/40001/tools/crashpad_database_util.cc File tools/crashpad_database_util.cc (right): https://codereview.chromium.org/1022663002/diff/40001/tools/crashpad_database_util.cc#newcode84 tools/crashpad_database_util.cc:84: bool StringToBool(const char* string, bool* boolean) { Robert Sesek ...
5 years, 9 months ago (2015-03-19 22:03:01 UTC) #4
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-19 22:09:18 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-19 22:41:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6f4e6aacc88562dbc144e76251792da742d4120f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698