Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: client/crash_report_database_test.cc

Issue 1022663002: Add crashpad_database_util and its man page (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crash_report_database_mac.mm ('k') | handler/mac/crashpad_handler.ad » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_test.cc
diff --git a/client/crash_report_database_test.cc b/client/crash_report_database_test.cc
index ff29b080d48f390ac73abc8b96a37d808f7cfe29..f065dd6957f5b9406ca12ada167331205d5ec3ea 100644
--- a/client/crash_report_database_test.cc
+++ b/client/crash_report_database_test.cc
@@ -372,8 +372,10 @@ TEST_F(CrashReportDatabaseTest, GetCompletedAndNotUploadedReports) {
EXPECT_EQ(4u, pending.size());
ASSERT_EQ(1u, completed.size());
- for (const auto& report : pending)
+ for (const auto& report : pending) {
EXPECT_NE(report_1_uuid, report.uuid);
+ EXPECT_FALSE(report.file_path.empty());
+ }
EXPECT_EQ(report_1_uuid, completed[0].uuid);
EXPECT_EQ("report1", completed[0].id);
EXPECT_EQ(true, completed[0].uploaded);
@@ -400,6 +402,7 @@ TEST_F(CrashReportDatabaseTest, GetCompletedAndNotUploadedReports) {
EXPECT_FALSE(report.uploaded);
EXPECT_TRUE(report.id.empty());
}
+ EXPECT_FALSE(report.file_path.empty());
}
// Upload a second report.
@@ -431,6 +434,7 @@ TEST_F(CrashReportDatabaseTest, GetCompletedAndNotUploadedReports) {
for (const auto& report : pending) {
EXPECT_TRUE(report.uuid == report_0_uuid ||
report.uuid == report_3_uuid);
+ EXPECT_FALSE(report.file_path.empty());
}
// Skip upload for one report.
@@ -459,6 +463,7 @@ TEST_F(CrashReportDatabaseTest, GetCompletedAndNotUploadedReports) {
EXPECT_GT(report.upload_attempts, 0);
EXPECT_GT(report.last_upload_attempt_time, 0);
}
+ EXPECT_FALSE(report.file_path.empty());
}
}
« no previous file with comments | « client/crash_report_database_mac.mm ('k') | handler/mac/crashpad_handler.ad » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698