Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: client/crash_report_database_mac.mm

Issue 1022663002: Add crashpad_database_util and its man page (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/crash_report_database_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_mac.mm
diff --git a/client/crash_report_database_mac.mm b/client/crash_report_database_mac.mm
index d588f7658cc26225cce860c604c685e19dd91914..f451efb0e0d96a3d14eaf48d2ffdc02bfd77f66a 100644
--- a/client/crash_report_database_mac.mm
+++ b/client/crash_report_database_mac.mm
@@ -573,15 +573,15 @@ CrashReportDatabase::OperationStatus CrashReportDatabaseMac::ReportsInDirectory(
reports->reserve([paths count]);
for (NSString* entry in paths) {
- base::FilePath report_path = path.Append([entry fileSystemRepresentation]);
- base::ScopedFD lock(ObtainReportLock(report_path));
+ Report report;
+ report.file_path = path.Append([entry fileSystemRepresentation]);
+ base::ScopedFD lock(ObtainReportLock(report.file_path));
if (!lock.is_valid())
continue;
- Report report;
- if (!ReadReportMetadataLocked(report_path, &report)) {
+ if (!ReadReportMetadataLocked(report.file_path, &report)) {
LOG(WARNING) << "Failed to read report metadata for "
- << report_path.value();
+ << report.file_path.value();
continue;
}
reports->push_back(report);
« no previous file with comments | « no previous file | client/crash_report_database_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698