Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1022203002: Followup to https://codereview.chromium.org/1001673002/ (Closed)

Created:
5 years, 9 months ago by scottmg
Modified:
5 years, 9 months ago
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix Thread::Join in win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M util/file/file_io_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M util/test/thread_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 9 months ago (2015-03-20 23:05:21 UTC) #1
scottmg
5 years, 9 months ago (2015-03-20 23:08:30 UTC) #3
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-20 23:13:52 UTC) #4
Robert Sesek
LGTM, thanks!
5 years, 9 months ago (2015-03-23 15:10:56 UTC) #5
scottmg
5 years, 9 months ago (2015-03-23 15:15:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0c704745dd65d8976bcebcd9cc9a87adcd65afdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698