util/file/file_io_posix.cc - Issue 1022203002: Followup to https://codereview.chromium.org/1001673002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/file_io_posix.cc

Issue 1022203002: Followup to https://codereview.chromium.org/1001673002/ (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: fix Thread::Join in win Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/file/file_io_posix.cc

diff --git a/util/file/file_io_posix.cc b/util/file/file_io_posix.cc

index 2f4709149b0c27a18e9fc28e828d3c062d54e888..a1f3b5d16820523a22ee563bb40a0c33a4edb4a3 100644

--- a/util/file/file_io_posix.cc

+++ b/util/file/file_io_posix.cc

@@ -102,7 +102,7 @@ FileHandle LoggingOpenFileForWrite(const base::FilePath& path,

}

bool LoggingLockFile(FileHandle file, FileLocking locking) {

- int operation = locking == FileLocking::kShared ? LOCK_SH : LOCK_EX;

+ int operation = (locking == FileLocking::kShared) ? LOCK_SH : LOCK_EX;

int rv = HANDLE_EINTR(flock(file, operation));

PLOG_IF(ERROR, rv != 0) << "flock";

return rv == 0;

« no previous file with comments | « no previous file | util/test/thread_win.cc » ('j') | no next file with comments »