Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: util/file/file_io_posix.cc

Issue 1022203002: Followup to https://codereview.chromium.org/1001673002/ (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: fix Thread::Join in win Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | util/test/thread_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 95
96 int fd = HANDLE_EINTR( 96 int fd = HANDLE_EINTR(
97 open(path.value().c_str(), 97 open(path.value().c_str(),
98 flags, 98 flags,
99 permissions == FilePermissions::kWorldReadable ? 0644 : 0600)); 99 permissions == FilePermissions::kWorldReadable ? 0644 : 0600));
100 PLOG_IF(ERROR, fd < 0) << "open " << path.value(); 100 PLOG_IF(ERROR, fd < 0) << "open " << path.value();
101 return fd; 101 return fd;
102 } 102 }
103 103
104 bool LoggingLockFile(FileHandle file, FileLocking locking) { 104 bool LoggingLockFile(FileHandle file, FileLocking locking) {
105 int operation = locking == FileLocking::kShared ? LOCK_SH : LOCK_EX; 105 int operation = (locking == FileLocking::kShared) ? LOCK_SH : LOCK_EX;
106 int rv = HANDLE_EINTR(flock(file, operation)); 106 int rv = HANDLE_EINTR(flock(file, operation));
107 PLOG_IF(ERROR, rv != 0) << "flock"; 107 PLOG_IF(ERROR, rv != 0) << "flock";
108 return rv == 0; 108 return rv == 0;
109 } 109 }
110 110
111 bool LoggingUnlockFile(FileHandle file) { 111 bool LoggingUnlockFile(FileHandle file) {
112 int rv = flock(file, LOCK_UN); 112 int rv = flock(file, LOCK_UN);
113 PLOG_IF(ERROR, rv != 0) << "flock"; 113 PLOG_IF(ERROR, rv != 0) << "flock";
114 return rv == 0; 114 return rv == 0;
115 } 115 }
116 116
117 FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) { 117 FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
118 off_t rv = lseek(file, offset, whence); 118 off_t rv = lseek(file, offset, whence);
119 PLOG_IF(ERROR, rv < 0) << "lseek"; 119 PLOG_IF(ERROR, rv < 0) << "lseek";
120 return rv; 120 return rv;
121 } 121 }
122 122
123 bool LoggingCloseFile(FileHandle file) { 123 bool LoggingCloseFile(FileHandle file) {
124 int rv = IGNORE_EINTR(close(file)); 124 int rv = IGNORE_EINTR(close(file));
125 PLOG_IF(ERROR, rv != 0) << "close"; 125 PLOG_IF(ERROR, rv != 0) << "close";
126 return rv == 0; 126 return rv == 0;
127 } 127 }
128 128
129 } // namespace crashpad 129 } // namespace crashpad
OLDNEW
« no previous file with comments | « no previous file | util/test/thread_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698