Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1021713004: Reorg Sk4x to match the pattern of SkPMFloat. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reorg Sk4x to match the pattern of SkPMFloat. No real changes here, just moving files around: - move impl files into src/opts - rename _portable _none BUG=skia: Committed: https://skia.googlesource.com/skia/+/f87cbcdf9f10120ca1821b4d6de94f7a2e94f930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -532 lines) Patch
M src/core/Sk4x.h View 2 chunks +9 lines, -9 lines 0 comments Download
D src/core/Sk4x_neon.h View 1 chunk +0 lines, -222 lines 0 comments Download
D src/core/Sk4x_portable.h View 1 chunk +0 lines, -120 lines 0 comments Download
D src/core/Sk4x_sse.h View 1 chunk +0 lines, -184 lines 0 comments Download
A + src/opts/Sk4x_neon.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/opts/Sk4x_none.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/opts/Sk4x_sse.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 15:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021713004/1
5 years, 9 months ago (2015-03-19 16:47:15 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 16:47:16 UTC) #5
reed1
lgtm
5 years, 9 months ago (2015-03-19 17:17:43 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 17:19:52 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f87cbcdf9f10120ca1821b4d6de94f7a2e94f930

Powered by Google App Engine
This is Rietveld 408576698