Have the browser process confirm creation of a persistent notification.

Have the browser process confirm creation of a persistent notification.

There are two reasons why this is going to be important:
  (1) With a database in the display path, there are failure cases.
  (2) After the SWR.showNotification() promise resolves, the developer
      should be able to assume it's included in SWR.getNotifications().

The browser process confirming display of the notification enables these
cases to be implemented reliably.

BUG=447628
Committed: https://crrev.com/1bca63ecfb185e669d10ece2920d8b4d56dba925
Cr-Commit-Position: refs/heads/master@{#322711}

[Peter Beverloo, 2015-03-20 18:14:35]

peter@chromium.org changed reviewers:
+ johnme@chromium.org, mkwst@chromium.org

[Peter Beverloo, 2015-03-20 18:14:36]

+johnme for notifications
+mkwst for IPC

With the CHECK in place in NotificationDispatcher this is safe. For now. I'll
refactor the IPC messages at some point (likely for 43) to get rid of the
NotificationDispatcher's token behavior altogether, by passing {notification_id
and thread_id} separately.

[Mike West, 2015-03-21 11:35:51]

IPC LGTM.

[johnme, 2015-03-23 18:49:01]

notifications lgtm with comment

https://codereview.chromium.org/1021293002/diff/1/content/browser/notificatio...
File content/browser/notifications/notification_message_filter.cc (right):

https://codereview.chromium.org/1021293002/diff/1/content/browser/notificatio...
content/browser/notifications/notification_message_filter.cc:127: if
(!VerifyNotificationPermissionGranted(service, origin))
Shouldn't this Send(new PlatformNotificationMsg_DidShowPersistent(request_id,
false)); ?

[Peter Beverloo, 2015-03-28 21:22:20]

Thank you for the reviews! :)

https://codereview.chromium.org/1021293002/diff/1/content/browser/notificatio...
File content/browser/notifications/notification_message_filter.cc (right):

https://codereview.chromium.org/1021293002/diff/1/content/browser/notificatio...
content/browser/notifications/notification_message_filter.cc:127: if
(!VerifyNotificationPermissionGranted(service, origin))
On 2015/03/23 18:49:00, johnme wrote:
> Shouldn't this Send(new PlatformNotificationMsg_DidShowPersistent(request_id,
> false)); ?

If this code is reached then the renderer has very likely been compromised -
resolving a promise is the least of our concerns. The BadMessageReceived()
method gets called on line 195 of this file.

[Peter Beverloo, 2015-03-28 21:53:57]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-03-28 21:53:57]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1021293002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2015-03-28 21:54:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021293002/20001

[commit-bot: I haz the power, 2015-03-28 23:15:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-28 23:15:57]

Patchset 2 (id:??) landed as
https://crrev.com/1bca63ecfb185e669d10ece2920d8b4d56dba925
Cr-Commit-Position: refs/heads/master@{#322711}