Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 1021293002: Have the browser process confirm creation of a persistent notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-BlowAway
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_message_filter.cc
diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc
index 99e13c0026b209066c632540e3deeeec796ac605..f1aa17a60ab9ba7fcafbeab5f55b480cc0f109cc 100644
--- a/content/browser/notifications/notification_message_filter.cc
+++ b/content/browser/notifications/notification_message_filter.cc
@@ -111,6 +111,7 @@ void NotificationMessageFilter::OnShowPlatformNotification(
}
void NotificationMessageFilter::OnShowPersistentNotification(
+ int request_id,
int64 service_worker_registration_id,
const GURL& origin,
const SkBitmap& icon,
@@ -129,6 +130,11 @@ void NotificationMessageFilter::OnShowPersistentNotification(
service->DisplayPersistentNotification(browser_context_,
service_worker_registration_id, origin,
icon, notification_data);
+
+ // TODO(peter): Confirm display of the persistent notification after the
+ // data has been stored using the |notification_context_|.
+ Send(new PlatformNotificationMsg_DidShowPersistent(request_id,
+ true /* success */));
}
void NotificationMessageFilter::OnGetNotifications(
« no previous file with comments | « content/browser/notifications/notification_message_filter.h ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698