content/child/notifications/notification_manager.h - Issue 1021293002: Have the browser process confirm creation of a persistent notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_manager.h

Issue 1021293002: Have the browser process confirm creation of a persistent notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-BlowAway

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_message_filter.cc ('k') | content/child/notifications/notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_manager.h

diff --git a/content/child/notifications/notification_manager.h b/content/child/notifications/notification_manager.h

index ae9a1ecbb8f8cadd514b94302973e7759a159bd8..7624198583cad49c5af4f8ce123c4ebcc9d3c59f 100644

--- a/content/child/notifications/notification_manager.h

+++ b/content/child/notifications/notification_manager.h

@@ -73,6 +73,7 @@ class NotificationManager : public blink::WebNotificationManager,

// IPC message handlers.

void OnDidShow(int notification_id);

+ void OnDidShowPersistent(int request_id, bool success);

void OnDidClose(int notification_id);

void OnDidClick(int notification_id);

void OnDidGetNotifications(

@@ -111,6 +112,10 @@ class NotificationManager : public blink::WebNotificationManager,

IDMap<blink::WebNotificationGetCallbacks, IDMapOwnPointer>

pending_get_notification_requests_;

+ // Tracks pending requests for displaying persistent notifications.

+ IDMap<blink::WebNotificationShowCallbacks, IDMapOwnPointer>

+ pending_show_notification_requests_;

// Map to store the delegate associated with a notification request Id.

std::map<int, blink::WebNotificationDelegate*> active_page_notifications_;