chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1021053003: Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@phase_splitting

Patch Set: Integration Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/tracked_objects_unittest.cc ('K') | « base/tracked_objects_unittest.cc ('k') | chrome/browser/metrics/first_web_contents_profiler.cc » ('j') | components/metrics/profiler/tracking_synchronizer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 328ebf7e28fc916c530553de054c6e1eb9a4a853..ee98ee5fb3d2865005bd3e7cf20682fe8016b5b1 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -377,8 +377,6 @@ void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() {

weak_ptr_factory_.GetWeakPtr());

}

-// TODO(vadimt): Consider wrapping params in a struct after the list of params

-// to ReceivedProfilerData settles. crbug/456354.

Alexei Svitkine (slow) 2015/03/30 18:31:21 Did you consider this? What's the reasoning for no

vadimt 2015/03/30 20:36:05 I'm waiting till we converge on the exact set of p

void ChromeMetricsServiceClient::ReceivedProfilerData(

const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,

base::ProcessId process_id,