Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

components/metrics/profiler/tracking_synchronizer_unittest.cc

Index: components/metrics/profiler/tracking_synchronizer_unittest.cc
diff --git a/components/metrics/profiler/tracking_synchronizer_unittest.cc b/components/metrics/profiler/tracking_synchronizer_unittest.cc
index 016532614bdbd8b9aaf8a0a85ec7d17ff2bd9b48..e55e7a3065c9592d0e09be82eb7e2b4c91097604 100644
--- a/components/metrics/profiler/tracking_synchronizer_unittest.cc
+++ b/components/metrics/profiler/tracking_synchronizer_unittest.cc
@@ -76,6 +76,27 @@ class TestObserver : public TrackingSynchronizerObserver {
   DISALLOW_COPY_AND_ASSIGN(TestObserver);
 };
 
+class TestTrackingSynchronizer : public TrackingSynchronizer {
+ public:
+  explicit TestTrackingSynchronizer(const base::TimeTicks& now)

[Alexei Svitkine (slow), 2015/03/30 18:31:21]

I think this should be passed by value. Same below.

+      : TrackingSynchronizer(now) {}
+
+  void RegisterPhaseCompletion(
+      ProfilerEventProto::ProfilerEvent profiling_event,
+      const base::TimeTicks& now) {
+    TrackingSynchronizer::RegisterPhaseCompletion(profiling_event, now);
+  }
+
+  ~TestTrackingSynchronizer() {}
+
+  void SendData(const tracked_objects::ProcessDataSnapshot& profiler_data,
+                content::ProcessType process_type,
+                const base::TimeTicks& now,
+                TrackingSynchronizerObserver* observer) const {
+    TrackingSynchronizer::SendData(profiler_data, process_type, now, observer);
+  }
+};
+
 base::TimeTicks TestTimeFromMs(int64 ms) {
   return base::TimeTicks() + base::TimeDelta::FromMilliseconds(ms);
 }
@@ -87,13 +108,11 @@ TEST(TrackingSynchronizerTest, ProfilerData) {
 
   content::TestBrowserThreadBundle thread_bundle;
 
-  scoped_refptr<TrackingSynchronizer> tracking_synchronizer =
-      new TrackingSynchronizer(TestTimeFromMs(111));
+  scoped_refptr<TestTrackingSynchronizer> tracking_synchronizer =
+      new TestTrackingSynchronizer(TestTimeFromMs(111));
 
-  // Mimic a phase change event.
-  tracking_synchronizer->phase_completion_events_sequence_.push_back(
-      ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT);
-  tracking_synchronizer->phase_start_times_.push_back(TestTimeFromMs(333));
+  tracking_synchronizer->RegisterPhaseCompletion(
+      ProfilerEventProto::EVENT_FIRST_NONEMPTY_PAINT, TestTimeFromMs(333));
 
   tracked_objects::ProcessDataSnapshot profiler_data;
   ProcessDataPhaseSnapshot snapshot0;