Delivering the FIRST_NONEMPTY_PAINT phase changing event to base/

chrome/browser/metrics/chrome_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 359 matching lines @@
 #endif  // defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
 }
 
 void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() {
   // Start the next part of the init task: fetching performance data.  This will
   // call into |FinishedReceivingProfilerData()| when the task completes.
   metrics::TrackingSynchronizer::FetchProfilerDataAsynchronously(
       weak_ptr_factory_.GetWeakPtr());
 }
 
-// TODO(vadimt): Consider wrapping params in a struct after the list of params
-// to ReceivedProfilerData settles. crbug/456354.

[Alexei Svitkine (slow), 2015/03/30 18:31:21]

Did you consider this? What's the reasoning for not doing it?

[vadimt, 2015/03/30 20:36:05]

I'm waiting till we converge on the exact set of params that we pass here, which
in turn depends completion of the whole CR.
We might end up with a pretty short list of params, in which case wrapping won't
be necessary.
I have a big red item in my spreadsheet to not forget doing this.

 void ChromeMetricsServiceClient::ReceivedProfilerData(
     const tracked_objects::ProcessDataPhaseSnapshot& process_data_phase,
     base::ProcessId process_id,
     content::ProcessType process_type,
     int profiling_phase,
     base::TimeDelta phase_start,
     base::TimeDelta phase_finish,
     const metrics::ProfilerEvents& past_events) {
   profiler_metrics_provider_->RecordProfilerData(
       process_data_phase, process_id, process_type, profiling_phase,
@@ skipping 170 matching lines @@
   // Capture the histogram samples.
   if (dumps_with_crash != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithCrash", dumps_with_crash);
   if (dumps_with_no_crash != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserDumpsWithNoCrash", dumps_with_no_crash);
   int total_dumps = dumps_with_crash + dumps_with_no_crash;
   if (total_dumps != 0)
     UMA_HISTOGRAM_COUNTS("Chrome.BrowserCrashDumpAttempts", total_dumps);
 }
 #endif  // defined(OS_WIN)