Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1020703002: Telemetry: Remove the class ProfileCreator. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Remove the class ProfileCreator. The class is replaced by ProfileExtender, which is functionally equivalent. Reparent SmallProfileCreator to inherit from FastNavigationProfileExtender, which cuts out all the deprecated code. This CL breaks ExtensionProfileCreator on Mac. That class will be fixed in a follow up CL. ExtensionProfileCreator is already broken on all other OSes, and it's not hooked into any tests. BUG= Committed: https://crrev.com/717cb4a9baad20757328c6a6170f2aee729c1263 Cr-Commit-Position: refs/heads/master@{#321454}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -139 lines) Patch
M tools/perf/profile_creators/fast_navigation_profile_extender.py View 1 chunk +2 lines, -1 line 0 comments Download
D tools/perf/profile_creators/large_profile_creator.py View 1 chunk +0 lines, -17 lines 0 comments Download
A + tools/perf/profile_creators/large_profile_extender.py View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/perf/profile_creators/profile_creator.py View 1 chunk +0 lines, -23 lines 0 comments Download
A + tools/perf/profile_creators/profile_extender.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/profile_creators/profile_generator.py View 5 chunks +23 lines, -23 lines 0 comments Download
D tools/perf/profile_creators/small_profile_creator.py View 1 chunk +0 lines, -71 lines 0 comments Download
A tools/perf/profile_creators/small_profile_extender.py View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
dtu: Please review.
5 years, 9 months ago (2015-03-19 01:33:18 UTC) #2
dtu
lgtm
5 years, 9 months ago (2015-03-19 21:36:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020703002/20001
5 years, 9 months ago (2015-03-19 21:38:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 22:34:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:35:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/717cb4a9baad20757328c6a6170f2aee729c1263
Cr-Commit-Position: refs/heads/master@{#321454}

Powered by Google App Engine
This is Rietveld 408576698