tools/perf/profile_creators/profile_creator.py - Issue 1020703002: Telemetry: Remove the class ProfileCreator.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/profile_creators/profile_creator.py

Issue 1020703002: Telemetry: Remove the class ProfileCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.

4

5 class ProfileCreator(object):

6 """Abstract base class for an object that constructs a Chrome profile."""

7

8 def Run(self, options):

9 """Creates the profile.

10

11 \|options\| is an instance of BrowserFinderOptions. When subclass

12 implementations of this method inevitably attempt to find and launch a

13 browser, they should pass \|options\| to the relevant methods.

14

15 Several properties of \|options\| might require direct manipulation by

16 subclasses. These are:

17 \|options.output_profile_path\|: The path at which the profile should be

18 created.

19 \|options.browser_options.profile_dir\|: If this property is None, then a

20 new profile is created. Otherwise, the existing profile is appended on

21 to.

22 """

23 raise NotImplementedError()

OLD	NEW